Export lora weights to sep file #14756
Open
+47
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/) [ghstack-poisoned]
lucylq
requested review from
jackzhxng,
larryliu0820,
swolchok and
mergennachin
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14756
Note: Links to docs will display an error until the docs builds have been completed. ❌ 9 New FailuresAs of commit 5f6bd76 with merge base d8a2126 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
lucylq
added a commit
that referenced
this pull request
Oct 2, 2025
Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/) ghstack-source-id: 313704499 Pull Request resolved: #14756
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/) [ghstack-poisoned]
This was referenced Oct 3, 2025
lucylq
added a commit
that referenced
this pull request
Oct 3, 2025
Pull Request resolved: #14756 ghstack-source-id: 313704499 @exported-using-ghexport Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
lucylq
changed the title
Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Oct 6, 2025
Pull Request resolved: #14756 ghstack-source-id: 314404070 @exported-using-ghexport Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Oct 6, 2025
Pull Request resolved: #14756 ghstack-source-id: 314404070 @exported-using-ghexport Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Oct 6, 2025
Pull Request resolved: #14756 ghstack-source-id: 314404070 @exported-using-ghexport Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Oct 6, 2025
Pull Request resolved: #14756 ghstack-source-id: 314404070 @exported-using-ghexport Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
shoumikhin
reviewed
Oct 7, 2025
|
|
||
| #include <gflags/gflags.h> | ||
| #include <sstream> | ||
| #include <vector> |
There was a problem hiding this comment.
nit: maybe some of these are already included by runer.h, etc
shoumikhin
approved these changes
Oct 7, 2025
Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Oct 7, 2025
Pull Request resolved: #14756 ghstack-source-id: 314432731 @exported-using-ghexport Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
lucylq
changed the title
Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Oct 7, 2025
Pull Request resolved: #14756 ghstack-source-id: 314455998 @exported-using-ghexport Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/) [ghstack-poisoned]
lucylq
added a commit
that referenced
this pull request
Oct 7, 2025
Pull Request resolved: #14756 ghstack-source-id: 314455998 @exported-using-ghexport Differential Revision: [D83777195](https://our.internmc.facebook.com/intern/diff/D83777195/)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D83777195